X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3UJQ0kl023741 for ; Mon, 30 Apr 2012 14:26:00 -0500 Received: from [128.162.232.130] (eagdhcp-232-130.americas.sgi.com [128.162.232.130]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9C33A304070; Mon, 30 Apr 2012 12:25:57 -0700 (PDT) Message-ID: <4F9EE745.9070408@sgi.com> Date: Mon, 30 Apr 2012 14:25:57 -0500 From: Mark Tinguely User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 MIME-Version: 1.0 To: Dave Chinner CC: xfs@oss.sgi.com Subject: Re: [PATCH 01/10] xfs: add trace points for log forces References: <1335249220-22274-1-git-send-email-david@fromorbit.com> <1335249220-22274-2-git-send-email-david@fromorbit.com> In-Reply-To: <1335249220-22274-2-git-send-email-david@fromorbit.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/24/12 01:33, Dave Chinner wrote: > From: Dave Chinner > > To enable easy tracing of the location of log forces and the > frequency of them via perf, add a pair of trace points to the log > force functions. This will help debug where excessive log forces > are being issued from by simple perf commands like: Good idea. Reviewed-by: Mark Tinguely