X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q4TF1Xbb234973 for ; Tue, 29 May 2012 10:01:33 -0500 Received: from whiskey.americas.sgi.com (whiskey.americas.sgi.com [128.162.233.19]) by relay2.corp.sgi.com (Postfix) with ESMTP id 42E90304032; Tue, 29 May 2012 08:01:29 -0700 (PDT) Received: by whiskey.americas.sgi.com (Postfix, from userid 4600) id 6C8CA44E47D; Tue, 29 May 2012 10:07:15 -0500 (CDT) Date: Tue, 29 May 2012 10:07:15 -0500 From: Ben Myers To: Dave Chinner Cc: xfs@oss.sgi.com Subject: Re: [PATCH] xfs: shutdown xfs_sync_worker before the log Message-ID: <20120529150715.GB4721@sgi.com> References: <20120323174327.GU7762@sgi.com> <20120514203449.GE16099@sgi.com> <20120516015626.GN25351@dastard> <20120516170402.GD3963@sgi.com> <20120517071658.GP25351@dastard> <20120524223952.GU16099@sgi.com> <20120525204536.GA4721@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120525204536.GA4721@sgi.com> User-Agent: Mutt/1.5.20 (2009-06-14) On Fri, May 25, 2012 at 03:45:36PM -0500, Ben Myers wrote: > On Thu, May 24, 2012 at 05:39:52PM -0500, Ben Myers wrote: > > Anyway, I'll make some time to work on this tomorrow so I can test it over > > the weekend. > > This is going to spin over the weekend. See what you think. I'm reasonably satisfied with the test results over the weekend. I did end up hitting an unrelated assert: [137111.090394] XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: /root/xfs/fs/xfs/xfs_bmap.c, line: 5635 Signed-off-by: Ben Myers