Resent-From: Dave Chinner <david@fromorbit.com>
Resent-Date: Mon, 18 Jun 2012 13:26:25 +1000
Resent-Message-ID: <20120618032625.GT19223@dastard>
Resent-To: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Date: Mon, 18 Jun 2012 12:30:04 +1000
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/7] xfs: do not read the AGI buffer in xfs_dialloc until
 nessecary
Message-ID: <20120618023004.GM19223@dastard>
References: <20120605144647.051012936@bombadil.infradead.org>
 <20120605144836.472805881@bombadil.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120605144836.472805881@bombadil.infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jun 05, 2012 at 10:46:53AM -0400, Christoph Hellwig wrote:
> Refactor the AG selection loop in xfs_dialloc to operate on the in-memory
> perag data as much as possible.  We only read the AGI buffer once we have
> selected an AG to allocate inodes now instead of for every AG considered.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok to me.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com