netdev
[Top] [All Lists]

Re: Resend: Re: PATCH: IPSEC acquire in presence of multiple managers

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: Resend: Re: PATCH: IPSEC acquire in presence of multiple managers
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 27 Mar 2005 05:27:40 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>, Shinta Sugimoto <shinta.sugimoto@xxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1111862131.1092.872.camel@jzny.localdomain>
References: <1111795927.1089.749.camel@jzny.localdomain> <1111862131.1092.872.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Sat, Mar 26, 2005 at 01:35:31PM -0500, jamal wrote:
>
>  int km_query(struct xfrm_state *x, struct xfrm_tmpl *t, struct xfrm_policy 
> *pol)
>  {
> -     int err = -EINVAL;
> +     int err = -EINVAL, acqret = -EINVAL;

BTW, you don't need to initialise acqret here since it's only used
inside the loop and is always assigned unconditionally..

> +             acqret = km->acquire(x, t, pol, XFRM_POLICY_OUT);
> +             if (!acqret)
> +                     err = acqret;

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>