xfs
[Top] [All Lists]

Re: [PATCH] xfstests: skip dump tests if dump utils not found

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: skip dump tests if dump utils not found
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Apr 2009 17:38:04 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <49EB8F90.20705@xxxxxxxxxxx>
References: <49EB8F90.20705@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Apr 19, 2009 at 03:54:40PM -0500, Eric Sandeen wrote:
> I was running xfstests on a NAS box which had no xfsdump,
> and any tests which required xfsdump were failing in not-so-nice
> ways:
> 
> > xfsdump not found
> 038      [failed, exit status 1] - output mismatch (see 038.out.bad)
> 
> I think using _notrun is a lot better:
> 
> 038      [not run] xfsdump not found
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good.

<Prev in Thread] Current Thread [Next in Thread>