xfs
[Top] [All Lists]

[PATCH 1/3] xfs: improve ioend error handling

To: xfs@xxxxxxxxxxx
Subject: [PATCH 1/3] xfs: improve ioend error handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 24 Aug 2011 01:59:25 -0400
References: <20110824055924.139283426@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
Return unwritten extent conversion errors to aio_complete.

Skip both unwritten extent conversion and size updates if we had an I/O error
or the filesystem has been shut down.

Return -EIO to the aio/buffer completion handlers in case of a forced shutdown.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/xfs/xfs_aops.c
===================================================================
--- xfs.orig/fs/xfs/xfs_aops.c  2011-08-23 04:27:32.031551647 +0200
+++ xfs/fs/xfs/xfs_aops.c       2011-08-23 04:35:20.822345321 +0200
@@ -88,8 +88,10 @@ xfs_destroy_ioend(
        }
 
        if (ioend->io_iocb) {
-               if (ioend->io_isasync)
-                       aio_complete(ioend->io_iocb, ioend->io_result, 0);
+               if (ioend->io_isasync) {
+                       aio_complete(ioend->io_iocb, ioend->io_error ?
+                                       ioend->io_error : ioend->io_result, 0);
+               }
                inode_dio_done(ioend->io_inode);
        }
 
@@ -141,9 +143,6 @@ xfs_setfilesize(
        xfs_inode_t             *ip = XFS_I(ioend->io_inode);
        xfs_fsize_t             isize;
 
-       if (unlikely(ioend->io_error))
-               return 0;
-
        if (!xfs_ilock_nowait(ip, XFS_ILOCK_EXCL))
                return EAGAIN;
 
@@ -189,17 +188,24 @@ xfs_end_io(
        struct xfs_inode *ip = XFS_I(ioend->io_inode);
        int             error = 0;
 
+       if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
+               error = -EIO;
+               goto done;
+       }
+       if (ioend->io_error)
+               goto done;
+
        /*
         * For unwritten extents we need to issue transactions to convert a
         * range to normal written extens after the data I/O has finished.
         */
-       if (ioend->io_type == IO_UNWRITTEN &&
-           likely(!ioend->io_error && !XFS_FORCED_SHUTDOWN(ip->i_mount))) {
-
+       if (ioend->io_type == IO_UNWRITTEN) {
                error = xfs_iomap_write_unwritten(ip, ioend->io_offset,
                                                 ioend->io_size);
-               if (error)
-                       ioend->io_error = error;
+               if (error) {
+                       ioend->io_error = -error;
+                       goto done;
+               }
        }
 
        /*
@@ -209,6 +215,7 @@ xfs_end_io(
        error = xfs_setfilesize(ioend);
        ASSERT(!error || error == EAGAIN);
 
+done:
        /*
         * If we didn't complete processing of the ioend, requeue it to the
         * tail of the workqueue for another attempt later. Otherwise destroy

<Prev in Thread] Current Thread [Next in Thread>