xfs
[Top] [All Lists]

Re: Review: xfs_bmapi does not update previous extent pointer correctly

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Review: xfs_bmapi does not update previous extent pointer correctly
From: Vlad Apostolov <vapo@xxxxxxx>
Date: Mon, 04 Jun 2007 15:26:27 +1000
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070604051944.GQ85884050@sgi.com>
References: <20070604051944.GQ85884050@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (X11/20070221)
It is looking good Dave,

Regards,
Vlad

David Chinner wrote:
When looping across multiple extents, xfs_bmapi will fail to
update the previous extent pointer which is used in subsequent
loops.

As a result, we can end up with the second loop in xfs_bmapi trying
to use an incorrect previous extent pointer and assert failures or
corrupted in-memory extent lists will result.

Correctly update the previous extent at the end of each loop so that
we DTRT when processing multiple map requests.

Cheers,

Dave.


<Prev in Thread] Current Thread [Next in Thread>