xfs
[Top] [All Lists]

Re: [fuse-devel] utimensat fails to update ctime

To: Jean-Pierre André <jean-pierre.andre@xxxxxxxxxx>
Subject: Re: [fuse-devel] utimensat fails to update ctime
From: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 02:58:03 +0900
Cc: Eric Blake <ebb9@xxxxxxx>, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, Miklos Szeredi <miklos@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4B30F0C9.2020702@xxxxxxxxxx> ("Jean-Pierre André"'s message of "Tue, 22 Dec 2009 17:16:09 +0100")
References: <4B2B156D.9040604@xxxxxxx> <87aaxclr4q.fsf@xxxxxxxxxxxxxxxxxxx> <4B2F7421.10005@xxxxxxx> <4B2F7A95.3010708@xxxxxxx> <87hbrkjrk8.fsf@xxxxxxxxxxxxxxxxxxx> <4B304D04.6040501@xxxxxxx> <87d427jscr.fsf@xxxxxxxxxxxxxxxxxxx> <4B3097C4.3060803@xxxxxxxxxx> <874onjjnln.fsf@xxxxxxxxxxxxxxxxxxx> <4B30B67A.7080703@xxxxxxxxxx> <87ljgvi1an.fsf@xxxxxxxxxxxxxxxxxxx> <4B30F0C9.2020702@xxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux)
Jean-Pierre André <jean-pierre.andre@xxxxxxxxxx> writes:

> Hi again,

Hi,

>> Yes.  AFAIK, fuse of kernel part is passing FATTR_MTIME without
>> FATTR_ATIME to userland (i.e. FUSE_SET_ATTR_ATIME and
>> FUSE_SET_ATTR_MTIME in libfuse).
>>
>> I think it's good to implement if it's not design decision of ntfs-3g.
>>
>> [BTW, just my guess though, it would be good to use "if (vaild&
>> ATTR_XXX)" style, not "switch()" to support various combinations of
>> flags]
>>    
>
> Might be better, ... or not. Setting both mtime
> and atime is much simpler than setting each one
> individually. So both methods will end up having
> to process three different situations.

Well, I don't care the implementation detail. However, the combination
might not be only three. E.g. if fs was exported as network fs's
backend, so many combinations are possible. So, specified known
combination can be fragile.

(e.g. ATTR_MTIME | ATTR_SIZE, etc, etc.)

> I suggest I port Miklos patch to fuse-lite soon,
> and delay the low-level case (and microsecond
> precision) until January. Does that suit your needs ?

Thanks. Sounds good. I'm not using ntfs-3g actually, I just bridged the
bug report on lkml to others. Eric?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>