xfs_fs_vcmn_err can be called under a spinlock, but does a sleeping memory allocation to create buffer for it's internal sprintf. Fortunately it's the only caller of icmn_err, so we can merge the two
Do we really want to drop the whole message if the fs name can't fit? Maybe drop the fsname altogether and print the error anyway? Being completely silent doesn't sound great... -Eric
That's what we effecitvely do now, except that we still call snprintf. I think it's an unlikely enough case that we don't need to worry about it. And if long enough device names become common we can