Mail Archive Search: <+subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+bulkstat\s+fixups\s*$/>

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+bulkstat\s+fixups\s*$/: 20 ]

Total 20 documents matching your query.

1. [PATCH] bulkstat fixups (score: 1): Author: Lachlan McIlroy <lachlan@xxxxxxx>; Date: Fri, 09 Nov 2007 16:24:02 +1100; Here's a collection of fixups for bulkstat for all the remaining issues. - sanity check for NULL user buffer in xfs_ioc_bulkstat[_compat]() - remove the special case for XFS_IOC_FSBULKSTAT with count; /archives/xfs/2007-11/msg00085.html (16,570 bytes)
2. Re: [PATCH] bulkstat fixups (score: 1): Author: Vlad Apostolov <vapo@xxxxxxx>; Date: Fri, 09 Nov 2007 16:35:20 +1100; It is looking good Lachlan. I also verified the patch with XFS QA and Judith reported that it fixed the xfs_bulkstat() problem - skipping inodes in the last AG. Regards, Vlad Lachlan McIlroy wrote: H; /archives/xfs/2007-11/msg00086.html (10,953 bytes)
3. Re: [PATCH] bulkstat fixups (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 12 Nov 2007 08:48:00 +1100; [Lachlan, can you wrap your email text at 72 columns for ease of quoting?] OK. Userspace visile change. What applications do we have that rely on this behaviour that will be broken by this change? Ok; /archives/xfs/2007-11/msg00097.html (12,090 bytes)
4. Re: [PATCH] bulkstat fixups (score: 1): Author: Lachlan McIlroy <lachlan@xxxxxxx>; Date: Mon, 12 Nov 2007 13:57:33 +1100; David Chinner wrote: [Lachlan, can you wrap your email text at 72 columns for ease of quoting?] On Fri, Nov 09, 2007 at 04:24:02PM +1100, Lachlan McIlroy wrote: Here's a collection of fixups for bulk; /archives/xfs/2007-11/msg00102.html (14,700 bytes)
5. Re: [PATCH] bulkstat fixups (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 12 Nov 2007 15:11:21 +1100; Perhaps, but we can't arbitrarily decide that those apps will now break on a new kernel with this change. At minimum we need to audit all of the code we have that uses bulkstat for such breakage (inc; /archives/xfs/2007-11/msg00110.html (12,677 bytes)
6. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Fri, 16 Nov 2007 15:34:40 +1100; Updated patch - I added cond_resched() calls into each loop - for loops that have a 'continue' somewhere in them I added the cond_resched() at the start, otherwise I put it at the end. David Chinner; /archives/xfs/2007-11/msg00164.html (20,460 bytes)
7. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Fri, 16 Nov 2007 15:42:54 +1100; Forgot to mention - this patch is just fs/xfs/xfs_itable.c. That's the only file that has been updated since the last patch. Lachlan McIlroy wrote: Updated patch - I added cond_resched() calls into e; /archives/xfs/2007-11/msg00165.html (14,491 bytes)
8. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Mon, 19 Nov 2007 14:02:44 +1100; You probably don't need the call in the innermost loop (the walking across the inode cluster). Sounds like it really is a bug as nothing is trying to exploit that behaviour. Ok, seems fair to fix it.; /archives/xfs/2007-11/msg00182.html (10,094 bytes)
9. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Wed, 21 Nov 2007 15:17:47 +0000; +#define XFS_BULKSTAT_UBLEFT(ubleft) ((ubleft) >= statstruct_size) I don't think this macro is really helpful. An inline would have been useful if statstruct_size was constant, but this way it's much; /archives/xfs/2007-11/msg00199.html (9,158 bytes)
10. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Thu, 22 Nov 2007 08:31:11 +1100; I think I mentioned that we don't need them in the innermost loop. The reason for adding them is that if the inode clusters are in cache, bulkstat will not yield the cpu at all and so holds off other; /archives/xfs/2007-11/msg00205.html (10,181 bytes)
11. [PATCH] bulkstat fixups (score: 1): Author:; Date: Fri, 09 Nov 2007 16:24:02 +1100; Here's a collection of fixups for bulkstat for all the remaining issues. - sanity check for NULL user buffer in xfs_ioc_bulkstat[_compat]() - remove the special case for XFS_IOC_FSBULKSTAT with count; /archives/xfs/2007-11/msg00401.html (16,570 bytes)
12. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Fri, 09 Nov 2007 16:35:20 +1100; It is looking good Lachlan. I also verified the patch with XFS QA and Judith reported that it fixed the xfs_bulkstat() problem - skipping inodes in the last AG. Regards, Vlad Lachlan McIlroy wrote: H; /archives/xfs/2007-11/msg00402.html (10,953 bytes)
13. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Mon, 12 Nov 2007 08:48:00 +1100; [Lachlan, can you wrap your email text at 72 columns for ease of quoting?] OK. Userspace visile change. What applications do we have that rely on this behaviour that will be broken by this change? Ok; /archives/xfs/2007-11/msg00413.html (12,090 bytes)
14. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Mon, 12 Nov 2007 13:57:33 +1100; David Chinner wrote: [Lachlan, can you wrap your email text at 72 columns for ease of quoting?] On Fri, Nov 09, 2007 at 04:24:02PM +1100, Lachlan McIlroy wrote: Here's a collection of fixups for bulk; /archives/xfs/2007-11/msg00418.html (14,700 bytes)
15. Re: [PATCH] bulkstat fixups (score: 1): Author:; Date: Mon, 12 Nov 2007 15:11:21 +1100; Perhaps, but we can't arbitrarily decide that those apps will now break on a new kernel with this change. At minimum we need to audit all of the code we have that uses bulkstat for such breakage (inc; /archives/xfs/2007-11/msg00426.html (12,677 bytes)
16. Re: [PATCH] bulkstat fixups (score: 1): Author: >; Date: Fri, 16 Nov 2007 15:34:40 +1100; Updated patch - I added cond_resched() calls into each loop - for loops that have a 'continue' somewhere in them I added the cond_resched() at the start, otherwise I put it at the end. David Chinner; /archives/xfs/2007-11/msg00480.html (20,460 bytes)
17. Re: [PATCH] bulkstat fixups (score: 1): Author: >; Date: Fri, 16 Nov 2007 15:42:54 +1100; Forgot to mention - this patch is just fs/xfs/xfs_itable.c. That's the only file that has been updated since the last patch. Lachlan McIlroy wrote: Updated patch - I added cond_resched() calls into e; /archives/xfs/2007-11/msg00481.html (14,491 bytes)
18. Re: [PATCH] bulkstat fixups (score: 1): Author: >; Date: Mon, 19 Nov 2007 14:02:44 +1100; You probably don't need the call in the innermost loop (the walking across the inode cluster). Sounds like it really is a bug as nothing is trying to exploit that behaviour. Ok, seems fair to fix it.; /archives/xfs/2007-11/msg00498.html (10,094 bytes)
19. Re: [PATCH] bulkstat fixups (score: 1): Author: >; Date: Wed, 21 Nov 2007 15:17:47 +0000; +#define XFS_BULKSTAT_UBLEFT(ubleft) ((ubleft) >= statstruct_size) I don't think this macro is really helpful. An inline would have been useful if statstruct_size was constant, but this way it's much; /archives/xfs/2007-11/msg00515.html (9,158 bytes)
20. Re: [PATCH] bulkstat fixups (score: 1): Author: >; Date: Thu, 22 Nov 2007 08:31:11 +1100; I think I mentioned that we don't need them in the innermost loop. The reason for adding them is that if the inode clusters are in cache, bulkstat will not yield the cpu at all and so holds off other; /archives/xfs/2007-11/msg00521.html (10,181 bytes)

Current List: 1 - 20
Page: [1]