- 1. [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Dave Chinner <david@xxxxxxxxxxxxx>
- Date: Fri, 3 Dec 2010 12:55:15 +1100
- We currently have a global error message buffer in cmn_err that is protected by a spin lock that disables interrupts. Recently there have been reports of NMI timeouts occurring when the console is be
- /archives/xfs/2010-12/msg00064.html (18,625 bytes)
- 2. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Lachlan McIlroy <lmcilroy@xxxxxxxxxx>
- Date: Thu, 2 Dec 2010 22:51:32 -0500 (EST)
- Dave, overall it looks good - just a few minor points below. Thanks for doing this. The old cmn_err() routine would append a newline if one was not supplied. As far as I know printk() will not do the
- /archives/xfs/2010-12/msg00065.html (24,441 bytes)
- 3. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Dave Chinner <david@xxxxxxxxxxxxx>
- Date: Fri, 3 Dec 2010 15:38:46 +1100
- FWIW, while these macros are the best way to make a simple backport is possible, I just discovered that mainline has a %pV format operator that allows an implementation like: void xfs_fs_cmn_err( con
- /archives/xfs/2010-12/msg00066.html (10,511 bytes)
- 4. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Dave Chinner <david@xxxxxxxxxxxxx>
- Date: Fri, 3 Dec 2010 19:36:59 +1100
- [snip] ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [snip] See above - I think you have it the wrong way around - it looks to me like the old cmn_err() stripped the newline character if it existed, then added one its
- /archives/xfs/2010-12/msg00069.html (13,392 bytes)
- 5. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Lachlan McIlroy <lmcilroy@xxxxxxxxxx>
- Date: Sun, 5 Dec 2010 20:40:46 -0500 (EST)
- That's the same thing - the input may or may not have a newline but the output always will. We should at least try to maintain that behaviour. What if the next message after a cmn_err() message doesn
- /archives/xfs/2010-12/msg00080.html (15,651 bytes)
- 6. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Fri, 10 Dec 2010 08:29:35 -0500
- With this we can also keep the existing integer-based CE_ values and do trivial array lookup. That also avoids having to do a strcmp for every message printed.
- /archives/xfs/2010-12/msg00159.html (9,093 bytes)
- 7. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Dave Chinner <david@xxxxxxxxxxxxx>
- Date: Mon, 13 Dec 2010 11:30:43 +1100
- Very true. Ok, so how do we want to process for this? I'm happy to drop the macro-ised patch and only use it as a backportable fix for old kernels - mainline appears to have a lot more functionality
- /archives/xfs/2010-12/msg00171.html (11,630 bytes)
- 8. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Lachlan McIlroy <lmcilroy@xxxxxxxxxx>
- Date: Sun, 12 Dec 2010 20:43:11 -0500 (EST)
- Yes, that works for me. We don't have much choice for RHEL4/5 and there's no reason that should compromise a better solution upstream. Wont you need to reintroduce the log level parameter when each o
- /archives/xfs/2010-12/msg00184.html (12,914 bytes)
- 9. Re: [PATCH] xfs: prevent NMI timeouts in cmn_err (score: 1)
- Author: Dave Chinner <david@xxxxxxxxxxxxx>
- Date: Mon, 13 Dec 2010 14:44:16 +1100
- Ok, I'll get that ball moving... Ah, what I meant was that the above xfs_pr_*() functions form the common logging interface, instead of cmn_err, xfs_cmn_err, xfs_fs_cmn_err, etc. So the second step a
- /archives/xfs/2010-12/msg00185.html (13,785 bytes)
This search system is powered by
Namazu