Thanks, Christoph. The 400k patch was too large for the vger email server so I have uploaded it to http://www.zip.com.au/~akpm/linux/patches/stuff/a-new-10gb-ethernet-driver-by-chelsio-communications
The performance recommendations in cxgb.txt are common to all fast devices, and should be in one file rather than just for this device. I would rather see ip-sysctl.txt updated or a new file on tunin
- my3126.c is unused (because t1_my3126_ops isn't used anywhere) - what are the EXTRA_CFLAGS in drivers/net/chelsio/Makefile for? - $(cxgb-y) in drivers/net/chelsio/Makefile seems to be unneeded - co
Andrew Morton wrote: Christoph Lameter <christoph@xxxxxxxxxx> wrote: A Linux driver for the Chelsio 10Gb Ethernet Network Controller by Chelsio (http://www.chelsio.com). This driver supports the Chel
Some of my usual coding style comments... Please do not introduce subsystem specific wrappers to kmalloc and kfree. Please drop the redundant casts and use kcalloc() here and in various other places
Few more coding style comments. Please drop this wrapper. kfree() handles null pointers so please drop the redundant check. Please drop the typedef. Please consider using dev_* helpers from <linux/d
Review comments (many) follow. Still needs work. Overall: t1_write_reg_4 and friends should be converted to native readl/writel functions. Don't use wrappers for low-level I/O functions. diff -puN /d
Thanks, Christoph. The 400k patch was too large for the vger email server so I have uploaded it to http://www.zip.com.au/~akpm/linux/patches/stuff/a-new-10gb-ethernet-driver-by-chelsio-communications
The performance recommendations in cxgb.txt are common to all fast devices, and should be in one file rather than just for this device. I would rather see ip-sysctl.txt updated or a new file on tunin
- my3126.c is unused (because t1_my3126_ops isn't used anywhere) - what are the EXTRA_CFLAGS in drivers/net/chelsio/Makefile for? - $(cxgb-y) in drivers/net/chelsio/Makefile seems to be unneeded - co
A Linux driver for the Chelsio 10Gb Ethernet Network Controller by Chelsio (http://www.chelsio.com). This driver supports the Chelsio N210 NIC and is backward compatible with the Chelsio N110 model
Some of my usual coding style comments... Please do not introduce subsystem specific wrappers to kmalloc and kfree. Please drop the redundant casts and use kcalloc() here and in various other places
Hi, Few more coding style comments. Please drop this wrapper. kfree() handles null pointers so please drop the redundant check. Please drop the typedef. Please consider using dev_* helpers from <linu
Review comments (many) follow. Still needs work. Overall: t1_write_reg_4 and friends should be converted to native readl/writel functions. Don't use wrappers for low-level I/O functions. diff -puN /d