Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Parenthesize\s+macros\s+in\s+xfs\s*$/: 22 ]

Total 22 documents matching your query.

1. Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Mon, 20 Mar 2006 22:09:31 +0100 (MET)
Hello xfs list, while browsing through the xfs/linux source, I noticed that many macros do not do proper bracing. I have started to cook up a patch, but would like feedback first before I continue fo
/archives/xfs/2006-03/msg00070.html (8,534 bytes)

2. Re: Parenthesize macros in xfs (score: 1)
Author: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 21 Mar 2006 08:23:27 +1100
Hi Jan, That looks fine. Please be sure to work on the -mm tree or on CVS on oss.sgi.com, so as to reduce your level of patch conflict. thanks. -- Nathan
/archives/xfs/2006-03/msg00071.html (8,854 bytes)

3. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Mon, 20 Mar 2006 22:39:45 +0100 (MET)
Hm, would not it even be better to make them 'static inline' functions? Jan Engelhardt --
/archives/xfs/2006-03/msg00073.html (9,025 bytes)

4. Re: Parenthesize macros in xfs (score: 1)
Author: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 21 Mar 2006 08:46:19 +1100
Hi Jan, Probably, I guess I'd want to see how invasive the patch becomes...? I really dislike those _ACL macros (around that example you gave, that could do with a cleanup all of its own - switching
/archives/xfs/2006-03/msg00074.html (9,667 bytes)

5. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sat, 25 Mar 2006 22:35:07 +0100 (MET)
To implement static inline, it requires that header files be corrected first so that they could 'compile on their own'. Shall I post a patch for that too? Here is the first patch in the series of 'f
/archives/xfs/2006-03/msg00087.html (16,000 bytes)

6. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 00:23:47 +0100 (MET)
It was missing before too. ;) Jan Engelhardt --
/archives/xfs/2006-03/msg00088.html (9,757 bytes)

7. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 00:26:50 +0100 (MET)
Here is the second patch in the row which tries to make every .h 'compile on its own'. It is not complete since the xfs directory (cvs copy) references things not present in ws (copy of 2.6.16, _not_
/archives/xfs/2006-03/msg00089.html (38,332 bytes)

8. Re: Parenthesize macros in xfs (score: 1)
Author: Andreas Schwab <schwab@xxxxxxx>
Date: Sun, 26 Mar 2006 00:45:19 +0100
No, previously it was provided at the call site. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54
/archives/xfs/2006-03/msg00090.html (10,495 bytes)

9. Re: Parenthesize macros in xfs (score: 1)
Author: Andreas Schwab <schwab@xxxxxxx>
Date: Sat, 25 Mar 2006 23:38:40 +0100
^^ Missing semicolon. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5
/archives/xfs/2006-03/msg00091.html (10,437 bytes)

10. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 11:26:41 +0200 (MEST)
Bad habit IMO. It does not hurt to provide it in both the macro and the call site, GCC can handle empty instructions. Jan Engelhardt --
/archives/xfs/2006-03/msg00094.html (9,771 bytes)

11. Re: Parenthesize macros in xfs (score: 1)
Author: Andreas Schwab <schwab@xxxxxxx>
Date: Sun, 26 Mar 2006 16:23:12 +0200
There is no way to provide the missing semicolon at the call site. swapfunc can't provide it either, since it's not a macro. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products
/archives/xfs/2006-03/msg00096.html (10,543 bytes)

12. Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Mon, 20 Mar 2006 22:09:31 +0100 (MET)
Hello xfs list, while browsing through the xfs/linux source, I noticed that many macros do not do proper bracing. I have started to cook up a patch, but would like feedback first before I continue fo
/archives/xfs/2006-03/msg00212.html (8,534 bytes)

13. Re: Parenthesize macros in xfs (score: 1)
Author: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 21 Mar 2006 08:23:27 +1100
Hi Jan, That looks fine. Please be sure to work on the -mm tree or on CVS on oss.sgi.com, so as to reduce your level of patch conflict. thanks. -- Nathan
/archives/xfs/2006-03/msg00213.html (8,854 bytes)

14. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Mon, 20 Mar 2006 22:39:45 +0100 (MET)
Hm, would not it even be better to make them 'static inline' functions? Jan Engelhardt --
/archives/xfs/2006-03/msg00215.html (9,025 bytes)

15. Re: Parenthesize macros in xfs (score: 1)
Author: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 21 Mar 2006 08:46:19 +1100
Hi Jan, Probably, I guess I'd want to see how invasive the patch becomes...? I really dislike those _ACL macros (around that example you gave, that could do with a cleanup all of its own - switching
/archives/xfs/2006-03/msg00216.html (9,667 bytes)

16. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sat, 25 Mar 2006 22:35:07 +0100 (MET)
To implement static inline, it requires that header files be corrected first so that they could 'compile on their own'. Shall I post a patch for that too? Here is the first patch in the series of 'f
/archives/xfs/2006-03/msg00229.html (16,000 bytes)

17. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 00:23:47 +0100 (MET)
It was missing before too. ;) Jan Engelhardt --
/archives/xfs/2006-03/msg00230.html (9,757 bytes)

18. Re: Parenthesize macros in xfs (score: 1)
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 00:26:50 +0100 (MET)
Here is the second patch in the row which tries to make every .h 'compile on its own'. It is not complete since the xfs directory (cvs copy) references things not present in ws (copy of 2.6.16, _not_
/archives/xfs/2006-03/msg00231.html (38,332 bytes)

19. Re: Parenthesize macros in xfs (score: 1)
Author: Andreas Schwab <schwab@xxxxxxx>
Date: Sun, 26 Mar 2006 00:45:19 +0100
No, previously it was provided at the call site. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54
/archives/xfs/2006-03/msg00232.html (10,495 bytes)

20. Re: Parenthesize macros in xfs (score: 1)
Author: Andreas Schwab <schwab@xxxxxxx>
Date: Sat, 25 Mar 2006 23:38:40 +0100
^^ Missing semicolon. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5
/archives/xfs/2006-03/msg00233.html (10,437 bytes)


This search system is powered by Namazu