This is a review request. PCP takes >12s to start, and pmlogger_check >10s (in the cases where its actually trying to start a pmlogger). ok, here it is. This is the 1st time I've gone this way.. i as
Ready! Review please.. In a number of cases ive moved loop iteration tests into the body.. this is because * its a good idea to try the target condition before the first sleep * its a good idea to tr
Repeating this in so many scripts is a bit of a shame, and it'd be better if they were faster always (not just is usleep found). We should implement a "pmsleep" command (like we did for pmhostname) i
Russell said something similar.. ok here it is: == mgmt/pcp/man/man1/GNUmakefile == -- a/mgmt/pcp/man/man1/GNUmakefile 2007-06-29 18:09:45.000000000 +1000 +++ b/mgmt/pcp/man/man1/GNUmakefile 2007-06-
Hi Michael, More complete review follows (thanks for implementing pmsleep btw)... The SEE ALSO section could probably reference sleep(1) and nanosleep(2). This variable just seems to be obfuscating t
BTW, one other thing I noticed here in the pmie and pmlogger check scripts - theres a comment near the start of the loop in _check_logger() that doesn't match what the code does. And the code looks w
Nathan Scott <nscott@xxxxxxxxxx> yep if you like yes ok dont understand. $i is incremented every time round. When it gets to 10 * it gets reset to zero * j is incremented * '.' is printed so $i count
Yep, I thought $delay was the loop step when I wrote that (hadn't seen the other two scripts then that really use it at that stage) - ignore that comment. the other here, only case I know of where yo
p_rlog only shows me back to 1.22, which still has the pre-exit sleep 5, i believe i'll make the agreed changes and retest. Unless something else happens in the meantime, i'll commit it.. this is tak
i decided to repost as ive tried to take on board favouring readability & conciseness over keeping the diffs short == mgmt/pcp/man/man1/GNUmakefile == -- a/mgmt/pcp/man/man1/GNUmakefile 2007-07-03 20
<paininbuttmode> This isn't quite right still, and I'm confused as to why you are looking for a halfway point between the old code and the simpler version that I posted? In particular: </paininbuttmo
<longsufferingmode> its so that you: "# dont sleep before 1st pid check, or after last" ..your version continues to have a final sleep which is not followed by a check (in this case, of whether the p
Light bulb goes on, I see how you're looking at it now - you're concerned about before _and_ after... (even though after doesn't matter), I thought you were hung up on _before_ only. So, in practice,
Hi Michael, More complete review follows (thanks for implementing pmsleep btw)... The SEE ALSO section could probably reference sleep(1) and nanosleep(2). This variable just seems to be obfuscating t
BTW, one other thing I noticed here in the pmie and pmlogger check scripts - theres a comment near the start of the loop in _check_logger() that doesn't match what the code does. And the code looks w
Nathan Scott <nscott@xxxxxxxxxx> yep if you like yes ok dont understand. $i is incremented every time round. When it gets to 10 * it gets reset to zero * j is incremented * '.' is printed so $i count
Yep, I thought $delay was the loop step when I wrote that (hadn't seen the other two scripts then that really use it at that stage) - ignore that comment. the other here, only case I know of where yo
p_rlog only shows me back to 1.22, which still has the pre-exit sleep 5, i believe i'll make the agreed changes and retest. Unless something else happens in the meantime, i'll commit it.. this is tak
i decided to repost as ive tried to take on board favouring readability & conciseness over keeping the diffs short == mgmt/pcp/man/man1/GNUmakefile == -- a/mgmt/pcp/man/man1/GNUmakefile 2007-07-03 20