Hi: In order for the skb trimming to work, we need to set truesize in pskb_expand_head. This patch does exactly that. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan
Dave, it hasn't been charged yet... -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: h
I tried to warn people about this earlier in the netlink NLMSG_GOODSIZE thread.... ho hum. This change mucks up socket buffer accounting. If you change skb->truesize, then when the kfree_skb(skb) hap
Well at least not in the netlink case. But you're that we can't do this in general. I'll adjust it right after the pskb_expand_head call then. Cheers, -- Visit Openswan at http://www.openswan.org/ Em
I still am hesitant about your idea. You're willing to do a very likely re-alloc every transaction where as I'm suggesting a single allocation for the socket at creation time which is used for every
Alright let's talk more about it :) Yes. However, what we really care about is not how many reallocations there are, but how likely are they going to fail. In your scheme, every netlink socket gets a
delta = skb->end - skb->tail which is the amount we want to trim. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apa